Swap GitHub and Terrform logos depending on light or dark mode#3264
Swap GitHub and Terrform logos depending on light or dark mode#3264thekbb wants to merge 9 commits intointegrations:mainfrom
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
|
Can we avoid committing the assets to source? We don't need another root folder No need to center them and take up vertical space. Let's just replace with proper logos. |
Thanks, @austenstone! I can definitely clean up the spacing layout to match the original. I was hoping to avoid committing the assets, but I ran into the same issue you did in #3278: when I upload them in a comment, the resulting user-attachments URL ends up 404ing. I'm all for advice, thoughts? |
|
here are the images, if you look at the URL it includes a If we can't find a solution for durable URL, would moving github-octocat-dark.svg: |
3 participants
Resolves #3263
Before the change?
When using GitHub's dark theme, the GitHub and Terraform logos are difficult to read:
After the change?
The Readme uses the picture element, which is supported in GitHub markdown, to swap out the assets depending on current theme.
The default is light mode.
Light theme:
Dark theme:
I added the svg assets to
readme-assets/, as well as slightly decreasing the size (height 50px, rather than 70px), and centered rather then left justified.The markdownlint.yaml file has a rule against in-line-html enabled. I've disabled it for the section I've added.
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!